-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fmt] setup.py and visualization #4726
Conversation
Hello @RMeli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-15 19:56:20 UTC |
Depends on https://github.com/MDAnalysis/mdanalysis/pulls and needs to be added to |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4726 +/- ##
===========================================
- Coverage 93.60% 93.58% -0.03%
===========================================
Files 173 185 +12
Lines 21464 22530 +1066
Branches 2993 2993
===========================================
+ Hits 20091 21084 +993
- Misses 929 1002 +73
Partials 444 444 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, sorry for the slow review!🐌
I didn't quite get this part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
But please wait with merging until after 2.8.0 release.
I asssume you'll also create/update .git-blame-ignore-revs
?
Yes. As discussed in #4725 (comment), I am tagging formatting PRs with |
Temporarily converted to draft to prevent an accidental merge before the release. |
Changes made in this Pull Request:
setup.py
visualisation/
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4726.org.readthedocs.build/en/4726/