Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] setup.py and visualization #4726

Merged
merged 28 commits into from
Nov 26, 2024
Merged

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Oct 3, 2024

Changes made in this Pull Request:

  • Automatic formatting of setup.py
  • Automatic formatting of visualisation/

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4726.org.readthedocs.build/en/4726/

RMeli added 27 commits June 6, 2022 21:53
@pep8speaks
Copy link

pep8speaks commented Oct 3, 2024

Hello @RMeli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 122:80: E501 line too long (118 > 79 characters)
Line 124:80: E501 line too long (118 > 79 characters)
Line 128:80: E501 line too long (89 > 79 characters)
Line 131:80: E501 line too long (89 > 79 characters)
Line 152:80: E501 line too long (88 > 79 characters)
Line 164:80: E501 line too long (116 > 79 characters)
Line 219:80: E501 line too long (81 > 79 characters)
Line 240:80: E501 line too long (104 > 79 characters)
Line 246:80: E501 line too long (107 > 79 characters)
Line 254:80: E501 line too long (89 > 79 characters)
Line 259:80: E501 line too long (98 > 79 characters)
Line 277:80: E501 line too long (118 > 79 characters)
Line 285:80: E501 line too long (112 > 79 characters)
Line 403:80: E501 line too long (114 > 79 characters)
Line 442:80: E501 line too long (103 > 79 characters)
Line 450:80: E501 line too long (117 > 79 characters)
Line 463:80: E501 line too long (116 > 79 characters)

Line 158:80: E501 line too long (80 > 79 characters)
Line 165:80: E501 line too long (85 > 79 characters)
Line 195:80: E501 line too long (112 > 79 characters)
Line 197:80: E501 line too long (81 > 79 characters)
Line 218:34: E203 whitespace before ':'
Line 221:34: E203 whitespace before ':'
Line 225:35: E203 whitespace before ':'
Line 232:35: E203 whitespace before ':'
Line 267:80: E501 line too long (117 > 79 characters)
Line 272:80: E501 line too long (117 > 79 characters)
Line 274:80: E501 line too long (118 > 79 characters)
Line 316:80: E501 line too long (115 > 79 characters)
Line 366:80: E501 line too long (91 > 79 characters)
Line 423:80: E501 line too long (113 > 79 characters)
Line 603:80: E501 line too long (113 > 79 characters)
Line 606:80: E501 line too long (118 > 79 characters)
Line 611:80: E501 line too long (112 > 79 characters)
Line 615:80: E501 line too long (114 > 79 characters)
Line 642:80: E501 line too long (113 > 79 characters)
Line 644:80: E501 line too long (101 > 79 characters)
Line 645:80: E501 line too long (109 > 79 characters)
Line 652:80: E501 line too long (83 > 79 characters)

Line 183:80: E501 line too long (80 > 79 characters)
Line 470:80: E501 line too long (82 > 79 characters)
Line 472:80: E501 line too long (85 > 79 characters)
Line 624:26: E203 whitespace before ':'

Comment last updated at 2024-10-15 19:56:20 UTC

@RMeli
Copy link
Member Author

RMeli commented Oct 3, 2024

Depends on https://github.com/MDAnalysis/mdanalysis/pulls and needs to be added to .git-blame-ignore-revs

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 52.33645% with 51 lines in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (48e9e01) to head (a76b31a).
Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
package/MDAnalysis/visualization/streamlines_3D.py 51.42% 33 Missing and 1 partial ⚠️
package/MDAnalysis/visualization/streamlines.py 52.77% 16 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4726      +/-   ##
===========================================
- Coverage    93.60%   93.58%   -0.03%     
===========================================
  Files          173      185      +12     
  Lines        21464    22530    +1066     
  Branches      2993     2993              
===========================================
+ Hits         20091    21084     +993     
- Misses         929     1002      +73     
  Partials       444      444              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RMeli RMeli changed the title [black] setup.py and visualization [fmt] setup.py and visualization Oct 15, 2024
@RMeli RMeli marked this pull request as ready for review October 30, 2024 08:17
@RMeli RMeli requested a review from marinegor November 5, 2024 10:50
Copy link
Contributor

@marinegor marinegor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry for the slow review!🐌

@marinegor
Copy link
Contributor

Depends on https://github.com/MDAnalysis/mdanalysis/pulls and needs to be added to .git-blame-ignore-revs

I didn't quite get this part

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But please wait with merging until after 2.8.0 release.

I asssume you'll also create/update .git-blame-ignore-revs ?

@RMeli
Copy link
Member Author

RMeli commented Nov 22, 2024

I asssume you'll also create/update .git-blame-ignore-revs ?

Yes. As discussed in #4725 (comment), I am tagging formatting PRs with [fmt] and they will be squash-merged. They will be added to .git-blame-ignore-revs once they are squash-merged (maybe pooling a few together).

@RMeli RMeli marked this pull request as draft November 22, 2024 07:19
@RMeli
Copy link
Member Author

RMeli commented Nov 22, 2024

Temporarily converted to draft to prevent an accidental merge before the release.

@RMeli RMeli marked this pull request as ready for review November 26, 2024 21:30
@RMeli RMeli merged commit 46be788 into MDAnalysis:develop Nov 26, 2024
22 of 24 checks passed
@RMeli RMeli deleted the root-and-visualization branch November 26, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants